Commit 7197cf34 authored by John Zhang's avatar John Zhang Committed by John Zhang

fix some minor errors.

There is a problem with classpath such that javadoc wasn't able to find
`commons.cli` package;
There are also small problems with using angle brackets `<` & `>` that
caused javadoc to complain 'malformed HTML tag'.

After this fix, the remaining errors are all about `@date` and `@id`
tags. These are not supported by javadoc. However they don't pose a
problem to the generated HTML document. So these problems are ignored
for now.
parent 03b84830
......@@ -60,7 +60,7 @@
<!-- include digest -->
<unjar src="${dacapo-digest-jar}" dest="${output-dir}" />
<javac srcdir="${src}" destdir="${output-dir}" debug="true" debuglevel="lines,vars,source"/>
<javadoc sourcepath="${src}" destdir="${output-doc-dir}" />
<javadoc sourcepath="${src}" destdir="${output-doc-dir}" classpath="${output-dir}"/>
</target>
<target name="jar">
......
......@@ -153,7 +153,6 @@ public abstract class Benchmark {
*
* @param callback The user-specified timing callback
* @param size The size (as given on the command line)
* @param timing Is this the timing loop ? Affects how we call the callback.
* @return Whether the run was valid or not.
* @throws Exception Whatever exception the target application dies with
*/
......@@ -337,7 +336,7 @@ public abstract class Benchmark {
/**
* An actual iteration of the benchmark. This is what is timed.
*
* @param args Arguments to the benchmark
* @param size Argument to the benchmark iteration.
*/
public abstract void iterate(String size) throws Exception;
......@@ -514,7 +513,7 @@ public abstract class Benchmark {
/**
* Perform post-iteration cleanup.
*
* @param size
* @param size Argument to the benchmark iteration.
*/
protected void postIterationCleanup(String size) {
for (String file : config.getOutputs(size)) {
......
......@@ -38,7 +38,6 @@ public class DacapoClassLoader extends URLClassLoader {
* @param scratch The scratch directory (in which the jars will be located)
* @return The class loader in which this benchmark's iterations should
* execute.
* @throws Exception
*/
public static DacapoClassLoader create(Config config, File scratch) {
DacapoClassLoader rtn = null;
......
......@@ -50,7 +50,7 @@ public class Slice {
/**
* Slice a file into a number of sub files. Output in the given directory.
* Files are called <input-file>.<fraction>.<numerator>.<index> such that file
* Files are called {input-file}.{fraction}.{numerator}.{index} such that file
* "x.4.3.1" is the first file, 3/4 of the size of the input file.
*
* @param file File to slice
......
......@@ -503,7 +503,7 @@ public class Config {
* Get the set of output files for a benchmark size
*
* @param size
* @return Set\<String\> of file names
* @return set of file name strings
*/
public Set<String> getOutputs(String size) {
return Collections.unmodifiableSet(getSize(size).outputFiles.keySet());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment