GitLab will be upgraded to the 12.10.14-ce.0 on 28 Sept 2020 at 2.00pm (AEDT) to 2.30pm (AEDT). During the update, GitLab and Mattermost services will not be available. If you have any concerns with this, please talk to us at N110 (b) CSIT building.

Commit d851145b authored by qinsoon's avatar qinsoon

[wip] remove reserve arg (we did it twice, so its nop)

parent a6998089
......@@ -3065,25 +3065,11 @@ impl <'a> InstructionSelection {
}
if !stack_args.is_empty() {
// deal with stack arg, put them on stack
// in reverse order, i.e. push the rightmost arg first to stack
stack_args.reverse();
// "The end of the input argument area shall be aligned on a 16
// (32, if __m256 is passed on stack) byte boundary." - x86 ABI
// if we need to special align the args, we do it now
// (then the args will be put to stack following their regular alignment)
// reserve stack args - we want to layout stack args as below
// RSP -> .............
// (padding)
// (padding)
// RSP -> argN, argN-1, ...
// so we need to layout args in reverse order
stack_args.reverse();
let stack_arg_tys = stack_args.iter().map(|x| x.ty.clone()).collect();
let (stack_arg_size, _, stack_arg_offsets) = BackendType::sequential_layout(&stack_arg_tys, vm);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment